Missing detail in help(ldf)

willwerscheid / flashier

A faster and angrier package for EBMF.

https://willwerscheid.github.io/flashier/

Other

10 stars 11 forks source link

Closed pcarbo closed 1 year ago

pcarbo commented 1 year ago

@willwerscheid It isn't clear from help(ldf) that you are returning the matrix factorization as

L %*% diag(D) %*% t(F)

That is, the D output is a vector and not a matrix.

willwerscheid commented 1 year ago

Just fixed now. Can you please take a look at commit ed195da5f7069eaf4255f4c58f0603851f04ae27 (0.2.55) before I close this?

pcarbo commented 1 year ago

Looks good, thanks!