search

willyamped / pe

0 stars 0 forks source link

Edit group does not detect "no change" #8

Open willyamped opened 3 years ago

willyamped commented 3 years ago

Steps to reproduce:

  1. edit 1 -g a

Screenshot 2021-11-12 at 4.58.17 PM.png

Expected: Editing a group named "a" to "a" should show some error message. Actual: Success message

nus-se-script commented 2 years ago

Team's Response

The edit command overwrites the student's information. It just so happens that you are overwriting it with the same information, but the command did execute as intended (i.e. a success that shows a success message)

As stated in the UG: "When editing tags and groups, all existing tags and groups of the student will be removed" It removes the existing group "a", and then allocates the student to group "a".

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Hi.. I believe that the main concern here is not how the team implemented the edit command. The main concern here is that there is no appropriate error message saying that there is no change because the user is editing something with the same thing.

Furthermore, based on your response, it seems as if different implementations may or may not produce the appropriate message. This should not be the case as the appropriate error message should still be shown regardless of the implementation.