search

willzeng / WikiNets

[deprecated] see cograph
https://github.com/willzeng/cograph
GNU General Public License v3.0
30 stars 11 forks source link

On node hover make text have a filled background Expander.coffee Line 50 #138

Open davidfurlong opened 10 years ago

willzeng commented 10 years ago

This is a bit complicated by there not being a background color attribute for the svg text element. Perhaps we'll need to create a rectangle behind all the text elements that appears and disappears?

i.e. here

backens commented 10 years ago

Is this issue referring to the node text or to toplink-instructions?

Line 50 in Expander.coffee is the latter. That is a span and thus has the css-attribute background-color, which means the change should be fairly straightforward. It might be good for toplink-instructions to have an opaque background anyway to improve legibility.

On 02/03/14 20:19, Will Zeng wrote:

This is a bit complicated by there not being a background color attribute for the svg text element. Perhaps we'll need to create a rectangle behind all the text elements that appears and disappears?

i.e. here

Reply to this email directly or view it on GitHub: https://github.com/willzeng/WikiNets/issues/138#issuecomment-36465265

willzeng commented 10 years ago

My bad, I misread this to refer to the node.text svg element. The change to toplink-instructions is easy.

davidfurlong commented 10 years ago

This is for node.text svg element

davidfurlong commented 10 years ago

The other (toplink) has already been given a 0.8 opacity white background on my branch