search

willzeng / WikiNets

[deprecated] see cograph
https://github.com/willzeng/cograph
GNU General Public License v3.0
30 stars 11 forks source link

Digifest cleanup #170

Closed willzeng closed 10 years ago

willzeng commented 10 years ago

This includes a lot of changes we've made to the interface. It would be good to get some eyes on the code. I'm currently going through it right now to make sure it is clean before implementing it.

If you would like to see a live version of this branch, then you can see it here: http://rhizi-digifest.herokuapp.com/

willzeng commented 10 years ago

@vpontis @backens

I've taken care of the issues you guys have flagged up (expecting only that I think there still may be some changes that need to be made to the require.js shim to properly load typeahead)

I'm leaning towards merging the branch now, not because it is exactly right, but because it seems better to work on a single branch. This one has way more changes then one would want in a single pull request. Thoughts?

vpontis commented 10 years ago

I've looked over the code a bit but there are a lot of changes and I still don't understand what everything does/how this code works.

My only question is: will this get us closer to the MVP? Will this add features and functionality that we need or only further complicate the code base? We really need to focus on refining and cutting things rather than adding new things. I should have a cleaned up search pull request soon.

VPontis

On Wed, Mar 19, 2014 at 8:29 PM, Will Zeng notifications@github.com wrote:

@vpontis https://github.com/vpontis @backenshttps://github.com/backens

I've taken care of the issues you guys have flagged up (expecting only that I think there still may be some changes that need to be made to the require.js shim to properly load typeahead)

I'm leaning towards merging the branch now, not because it is exactly right, but because it seems better to work on a single branch. This one has way more changes then one would want in a single pull request. Thoughts?

Reply to this email directly or view it on GitHubhttps://github.com/willzeng/WikiNets/pull/170#issuecomment-38102709 .

willzeng commented 10 years ago

You are absolutely right @vpontis and this merge, unfortunately, both complicates the codebase some and adds functionality towards the MVP. On balance I think it adds enough functionality that we can add it, but the balance is only just that way.

This is the last "messy" merge that will happen.