search

willzeng / WikiNets

[deprecated] see cograph
https://github.com/willzeng/cograph
GNU General Public License v3.0
30 stars 11 forks source link

Clean up the search modules #173

Open vpontis opened 10 years ago

vpontis commented 10 years ago

@willzeng I think we should combine the search modules into one. It really doesn't make sense having more than one type of search, it just adds complexity. Initially search should just look in the names of nodes or descriptions (whatever we decide) and just pull up all nodes that match.

We should decide the behavior but it should be really simple and intuitive. I am in favor of returning the nodes that match and clearing out all other nodes. This allows searches for multiple things to happen in quick secession.

willzeng commented 10 years ago

The SimpleSearchBox is set up to do the sort of search you suggest.

Right now it adds nodes to the workspace if they are not there, and then selects the results. The reason it doesn't clear the workspace, is that often you will be looking at something and want to bring up some new things as context or to link to, without losing what you are already looking at.

SimpleSearchBox is then the plugin to clean up first.

On Tue, Mar 18, 2014 at 1:46 AM, Victor Pontis notifications@github.comwrote:

@willzeng https://github.com/willzeng I think we should combine the search modules into one. It really doesn't make sense having more than one type of search, it just adds complexity. Initially search should just look in the names of nodes or descriptions (whatever we decide) and just pull up all nodes that match.

We should decide the behavior but it should be really simple and intuitive. I am in favor of returning the nodes that match and clearing out all other nodes. This allows searches for multiple things to happen in quick secession.

Reply to this email directly or view it on GitHubhttps://github.com/willzeng/WikiNets/issues/173#issuecomment-37891967 .

vpontis commented 10 years ago

OK sweet. We should try to think about some way to really distinguish the search nodes. Also for this behavior we need to address some edge cases.

Do the currently searched for nodes disappear on the next search? Otherwise, you are not going to be able to multiple searches in quick succession because you are going to have too many nodes on the screen.

What happens if the node that you search for is already displayed? If we are making searched nodes disappear on the next search, will it disappear or will it disappear?

What I am trying to get across is that this behavior is actually quite complicated and we need to about a way of formulating search so that it is intuitive to the user.

VPontis

On Tue, Mar 18, 2014 at 9:16 AM, Will Zeng notifications@github.com wrote:

The SimpleSearchBox is set up to do the sort of search you suggest.

Right now it adds nodes to the workspace if they are not there, and then selects the results. The reason it doesn't clear the workspace, is that often you will be looking at something and want to bring up some new things as context or to link to, without losing what you are already looking at.

SimpleSearchBox is then the plugin to clean up first.

On Tue, Mar 18, 2014 at 1:46 AM, Victor Pontis <notifications@github.com

wrote:

@willzeng https://github.com/willzeng I think we should combine the search modules into one. It really doesn't make sense having more than one type of search, it just adds complexity. Initially search should just look in the names of nodes or descriptions (whatever we decide) and just pull up all nodes that match.

We should decide the behavior but it should be really simple and intuitive. I am in favor of returning the nodes that match and clearing out all other nodes. This allows searches for multiple things to happen in quick secession.

Reply to this email directly or view it on GitHub< https://github.com/willzeng/WikiNets/issues/173#issuecomment-37891967> .

Reply to this email directly or view it on GitHubhttps://github.com/willzeng/WikiNets/issues/173#issuecomment-37912155 .

willzeng commented 10 years ago

"Do the currently searched for nodes disappear on the next search? Otherwise, you are not going to be able to multiple searches in quick succession because you are going to have too many nodes on the screen."

I see your point, but am not sure of when someone would want to do many searches in quick succession without keeping any of the results on the workspace. Can you think of a motivating example?

"What happens if the node that you search for is already displayed? If we are making searched nodes disappear on the next search, will it disappear or will it disappear?"

Right now this node is just selected. This sort of concern leads me to think that we shouldn't have recently searched nodes disappear on the next search.

vpontis commented 10 years ago

So I think the use case for multiple searches is when you don't know exactly what you are looking for. I see myself doing this all the time when I am looking through my notes. I know that I wrote something down but I forgot if I tagged it #idea or #ideas or #thought or something like that. I see multiple searches as something that I do a lot but that may be different for you guys.

VPontis

On Thu, Mar 20, 2014 at 1:25 PM, Will Zeng notifications@github.com wrote:

"Do the currently searched for nodes disappear on the next search? Otherwise, you are not going to be able to multiple searches in quick succession because you are going to have too many nodes on the screen."

I see your point, but am not sure of when someone would want to do many searches in quick succession without keeping any of the results on the workspace. Can you think of a motivating example?

"What happens if the node that you search for is already displayed? If we are making searched nodes disappear on the next search, will it disappear or will it disappear?"

Right now this node is just selected. This sort of concern leads me to think that we shouldn't have recently searched nodes disappear on the next search.

Reply to this email directly or view it on GitHubhttps://github.com/willzeng/WikiNets/issues/173#issuecomment-38160584 .

willzeng commented 10 years ago

This is a good point. I don't have a solution let. Let's muse on it a little.

On Fri, Mar 21, 2014 at 3:33 PM, Victor Pontis notifications@github.comwrote:

So I think the use case for multiple searches is when you don't know exactly what you are looking for. I see myself doing this all the time when I am looking through my notes. I know that I wrote something down but I forgot if I tagged it #idea or #ideas or #thought or something like that. I see multiple searches as something that I do a lot but that may be different for you guys.

VPontis

On Thu, Mar 20, 2014 at 1:25 PM, Will Zeng notifications@github.com wrote:

"Do the currently searched for nodes disappear on the next search? Otherwise, you are not going to be able to multiple searches in quick succession because you are going to have too many nodes on the screen."

I see your point, but am not sure of when someone would want to do many searches in quick succession without keeping any of the results on the workspace. Can you think of a motivating example?

"What happens if the node that you search for is already displayed? If we are making searched nodes disappear on the next search, will it disappear or will it disappear?"

Right now this node is just selected. This sort of concern leads me to think that we shouldn't have recently searched nodes disappear on the next search.

Reply to this email directly or view it on GitHub< https://github.com/willzeng/WikiNets/issues/173#issuecomment-38160584> .

Reply to this email directly or view it on GitHubhttps://github.com/willzeng/WikiNets/issues/173#issuecomment-38287841 .