willzeng / cograph

A way to build and explore webs of ideas.
http://www.cograph.co/
GNU General Public License v2.0
15 stars 3 forks source link

Workspace positions #513

Closed willzeng closed 10 years ago

willzeng commented 10 years ago

Fixes #496

Saving a workspace now saves the exact positions of all nodes on the workspace. When you load up that workspace, nodes are placed in their positions and set to fixed.

davidfurlong commented 10 years ago

bug saving a view -> going to open doesn't display the saved view. Only after a reload does it appear

davidfurlong commented 10 years ago

Ok opening a view is taking me to http://localhost:3000/236452#348468 (which redirects to http://localhost:3000/236452) instead of http://localhost:3000/236452/view/348468 is this a general problem or a backwards compatibility problem?

davidfurlong commented 10 years ago

improvement the zoom / translation of the graph needs to be saved too

willzeng commented 10 years ago

bug saving a view -> going to open doesn't display the saved view. Only after a reload does it appear

This is an issue separate from this branch: https://github.com/willzeng/graphdocs/issues/515

Ok opening a view is taking me to http://localhost:3000/236452#348468 (which redirects to http://localhost:3000/236452) instead of http://localhost:3000/236452/view/348468 is this a general problem or a backwards compatibility problem?

I do not see this behavior. Are you sure that you are looking at a document that has a createdBy author? That sort of redirection could also happen if the workspace no longer exists. Also, urls which are not localhost:3000/author/document/id are deprecated, so we should be sure to test on the real routes.

Will do the zoom/translation thing.

davidfurlong commented 10 years ago

That sort of redirection could also happen if the workspace no longer exists. Also, urls which are not localhost:3000/author/document/id are deprecated, so we should be sure to test on the real routes.

ok its just an old document created by a different standard then.

willzeng commented 10 years ago

@davidfurlong ready to check this out