search

willzeng / cograph

A way to build and explore webs of ideas.
http://www.cograph.co/
GNU General Public License v2.0
15 stars 3 forks source link

removed text color and added less build in npm start script #565

Closed davidfurlong closed 9 years ago

willzeng commented 9 years ago

are you sure we want to remove text color? I think it would be better if we just chose colors that had better contrast.

Color is a great way to make the graphs more readable and the nodes are a bit too small to make that easy I think.

davidfurlong commented 9 years ago

yeah alright

davidfurlong commented 9 years ago

@willzeng I darkened the text colors from the original node colors

davidfurlong commented 9 years ago

@willzeng fixes #567

willzeng commented 9 years ago

why are we doing this with a method rather than just hard coding in new different values?

davidfurlong commented 9 years ago

why are we doing this with a method rather than just hard coding in new different values?

because we aren't always going to have these colors. Things change and hardcoding would be bad practice when we do want to change things

willzeng commented 9 years ago

Oh I see what you're doing now. The text color is always just a shaded darker version of the node color.

I had been thinking that we would just darken the node colors too. Is it better for them to be different from a design perspective?

davidfurlong commented 9 years ago

I had been thinking that we would just darken the node colors too. Is it better for them to be different from a design perspective?

Hm.. Not particularly but I'd rather have it like it is currently..