Closed davidfurlong closed 9 years ago
yeah alright
@willzeng I darkened the text colors from the original node colors
@willzeng fixes #567
why are we doing this with a method rather than just hard coding in new different values?
why are we doing this with a method rather than just hard coding in new different values?
because we aren't always going to have these colors. Things change and hardcoding would be bad practice when we do want to change things
Oh I see what you're doing now. The text color is always just a shaded darker version of the node color.
I had been thinking that we would just darken the node colors too. Is it better for them to be different from a design perspective?
I had been thinking that we would just darken the node colors too. Is it better for them to be different from a design perspective?
Hm.. Not particularly but I'd rather have it like it is currently..
are you sure we want to remove text color? I think it would be better if we just chose colors that had better contrast.
Color is a great way to make the graphs more readable and the nodes are a bit too small to make that easy I think.