willzeng / cograph

A way to build and explore webs of ideas.
http://www.cograph.co/
GNU General Public License v2.0
15 stars 3 forks source link

Adding plus #566

Closed willzeng closed 4 years ago

willzeng commented 9 years ago

It is now possible to use the + connector in the addnode to connect with nodes that are hidden from the workspace and to make new nodes that are automatically connected to.

@davidfurlong give it a check over for bugs. I think a code review might also find some ways to simplify the implementation before merge.

davidfurlong commented 9 years ago

this isn't working properly.

davidfurlong commented 9 years ago
  1. can't have a node title with a space
  2. goes wrong sometimes
willzeng commented 9 years ago

I don't know of any good workaround for number 1. This is something I just think we'll be unable to support for now.

Can you replicate when it goes wrong?

davidfurlong commented 9 years ago

Yeah. I put "David Furlong" off the workspace. I add a new node and do +David Furl and hit autocomplete it. It pulls the node onto the workspace and when I create the new node it creates it to a new node called "David" and connects to that instead.

willzeng commented 9 years ago

ahhh got it. I know how to fix that behavior. I just need to prioritize for existing multiwords of that kind.

Will do.

davidfurlong commented 9 years ago

ahhh got it. I know how to fix that behavior. I just need to prioritize for existing multiwords of that kind.

Will do.

I really think we should make sure that the quality of the stuff we add is high. We should definitely have the text show up blue if it is part of a tag or reference inside of the textarea. That way we can do multi word adds in the text area too (by having you have to click outside of the blue area or press tab or something)

willzeng commented 9 years ago

shoot actually I see your point. I'm not sure what a slick way to fix this edge case is. We can leave it out for now and I'll thinking about it tomorrow morning. Perhaps the coloring things wouldn't take as long as I think.