search

willzeng / cograph

A way to build and explore webs of ideas.
http://www.cograph.co/
GNU General Public License v2.0
15 stars 3 forks source link

atwho is must load stably #578

Closed willzeng closed 9 years ago

willzeng commented 9 years ago

Does not do so now. Needs to be replicated

willzeng commented 9 years ago

@davidfurlong damn I am having a ton of trouble getting this bug to explain itself. My intuition is that there is some kind of loading race condition where atwho isn't loading.

This would explain why I only sometimes seem to see the error and that it appears on load (or on expand of that addNodeView)

Still there shouldn't be a condition since require is explicitly! loading at who in AddNodeView!

ugh, do you have any extra ideas on this bug?

davidfurlong commented 9 years ago

@davidfurlong damn I am having a ton of trouble getting this bug to explain itself. My intuition is that there is some kind of loading race condition where atwho isn't loading.

This would explain why I only sometimes seem to see the error and that it appears on load (or on expand of that addNodeView)

Still there shouldn't be a condition since require is explicitly! loading at who in AddNodeView!

ugh, do you have any extra ideas on this bug?

I looked at the code, didnt see much. Your fork of atwho is well behind atwho master, perhaps if we merge master in the problems have been patched?

willzeng commented 9 years ago

yep, didn't work when I pushed it to production. I have been troubleshooting again for a few hours

willzeng commented 9 years ago

well, I tried this: https://github.com/willzeng/graphdocs/commit/487d87402706bd35c94766329b0d8f32b2fca26e

and it didn't work