search

willzeng / cograph

A way to build and explore webs of ideas.
http://www.cograph.co/
GNU General Public License v2.0
15 stars 3 forks source link

Load atwho and caret explicitly in main with require #585

Closed willzeng closed 9 years ago

willzeng commented 9 years ago

@davidfurlong This seems to improve things on production as I have not gotten the error on atwho after making this change.

Addresses #578

I did once see the error with bbmodal that you mentioned and am thinking of trying this same fix with it, but have run into some other weird bugs that get introduced.

In any case, see if this works to fix the atwho bug for you. This is the branch that is currently on http://www.cograph.co/

willzeng commented 9 years ago

Does it seem to eliminate the bug for you as well?

On Thu, Nov 6, 2014 at 6:57 AM, David Furlong notifications@github.com wrote:

Merged #585.

Reply to this email directly or view it on GitHub: https://github.com/willzeng/graphdocs/pull/585#event-189345458

davidfurlong commented 9 years ago

Does it seem to eliminate the bug for you as well?

Ay. But the modal bug remains

willzeng commented 9 years ago

YES!! I will take a similar approach and start fixing the bbmodal (though the naive extention of just requiring bbmodal and its deps reintroduced new bugs)

On Fri, Nov 7, 2014 at 2:25 AM, David Furlong notifications@github.com wrote:

Does it seem to eliminate the bug for you as well?

Ay. But the modal bug remains

Reply to this email directly or view it on GitHub: https://github.com/willzeng/graphdocs/pull/585#issuecomment-62124152