search

willzeng / cograph

A way to build and explore webs of ideas.
http://www.cograph.co/
GNU General Public License v2.0
15 stars 3 forks source link

fixes search variable width #586

Closed davidfurlong closed 9 years ago

davidfurlong commented 9 years ago

fixes #580

not merge ready - needs to be put in a css file & needs to fix the other search bugs

willzeng commented 9 years ago

@davidfurlong Are there fixes/updates to this?

willzeng commented 9 years ago

Is there anything major that needs to be done here or is this a quick fix to get mergeable?

davidfurlong commented 9 years ago

https://github.com/willzeng/graphdocs/issues/580

willzeng commented 9 years ago

roger that

On Tue Dec 16 2014 at 12:48:04 David Furlong notifications@github.com wrote:

580 https://github.com/willzeng/graphdocs/issues/580

— Reply to this email directly or view it on GitHub https://github.com/willzeng/graphdocs/pull/586#issuecomment-67154540.

davidfurlong commented 9 years ago

@willzeng making results clickable is proving difficult, it has to do with the fact that we are doing position relative and not absolute for the dropdown menu and I can't get event listeners onto it.. kindof a typeahead problem.

willzeng commented 9 years ago

If it seems like that issue will delay things, then move it into its own new issue and we can take care of the clickability separately. (its an important feature though, esp. for mobile)

If you choose to do that then let me know and I will check this one out for merge.

davidfurlong commented 9 years ago

Ok well lets merge this and handle the other issue later