search

willzeng / cograph

A way to build and explore webs of ideas.
http://www.cograph.co/
GNU General Public License v2.0
15 stars 3 forks source link

fix node collection fetch asyn loop bugs. This fixes showall errors #613

Closed willzeng closed 9 years ago

willzeng commented 9 years ago

Fixes #606 and also addresses #590

@davidfurlong This is ready for merge consideration. Also check to see if it has fixed #590 when it is merged.

davidfurlong commented 9 years ago

Ok so 1) its a bit slow? 2) Bug: Hide a node, delete a different one, show-all goes from 1 to 0.

willzeng commented 9 years ago

(2) is because it is doing a show all after node deletion for some reason. Will fix

willzeng commented 9 years ago

The loading delay was coming from the time to render the graph layout not from fetching from the server. It was always assuming it needed to rerender the whole graph.
Have now changed it to be dynamic, based on the number of unhidden nodes.

@davidfurlong Should be ready for merge consideration.

willzeng commented 9 years ago

once this is in and everything is checked we will be done with the STABLE MILESTONE!!!