willzeng / cograph

A way to build and explore webs of ideas.
http://www.cograph.co/
GNU General Public License v2.0
15 stars 3 forks source link

Adds necessary two arguments to the app.use session constructor #640

Closed davidfurlong closed 9 years ago

davidfurlong commented 9 years ago

See https://github.com/expressjs/session#options for reference

solves the two deprecated warnings on start

harlantwood commented 9 years ago

Nice. I still get one warning on startup when on the branch:

 [small-app-session-fix] $ bin/www 
express-session deprecated undefined saveUninitialized option; provide saveUninitialized option app.coffee:66:11

Some of my local versions:

 [small-app-session-fix] $ npm ls|grep express
├─┬ express@4.0.0
├── express-flash@0.0.2
├─┬ express-session@1.11.2
├─┬ express.io@1.1.13
│ ├─┬ express@3.4.8
davidfurlong commented 9 years ago

Nice. I still get one warning on startup when on the branch:

It had a typo and I forgot to commit the fix.

harlantwood commented 9 years ago

LGTM :+1: