willzeng / cograph

A way to build and explore webs of ideas.
http://www.cograph.co/
GNU General Public License v2.0
15 stars 3 forks source link

Refactor stylesheets to be appropriate for build #644

Open willzeng opened 9 years ago

willzeng commented 9 years ago

Option 1:

Resolve conflicts between page specific stylesheets by adding classes if necessary Maintain a no conflicts policy between page styles Have 2 minified css files

Option 2: Keep css files the way that they are Have a minified css file which consists of a set css files for each page.

As for performance differences, a) both solutions have the same # of HTTP requests b) Option 2 will have smaller # of rules in minified stylesheets c) In Option 1, stylesheet HTTP request will cache across pages, whilst Option 2 wont d) The cost (in time) of HTTP requests is greater than the css drawing time for small stylesheets

I think Option 1 may be preferable for the size of the stylesheets we currently have (for performance and convenience)

This should be done by working off of #642

harlantwood commented 9 years ago

+1 for this fix; either option sounds reasonable to me.