search

willzeng / cograph

A way to build and explore webs of ideas.
http://www.cograph.co/
GNU General Public License v2.0
15 stars 3 forks source link

Deploy w/ css #647

Open davidfurlong opened 9 years ago

willzeng commented 9 years ago

Rad man. While this is now properly loading the .css, it doesn't seem to be fetching the .js files properly:

http://graphdocs-test.herokuapp.com/

Have you deployed it to heroku to test somewhere @davidfurlong ?

harlantwood commented 9 years ago

Glad to see this moving :)

harlantwood commented 9 years ago

@davidfurlong: when I tried a test deploy, it errored out looking for colors.less:

fontawesome#4.2.0 app/assets/libs/fontawesome
The compress option has been deprecated. We recommend you use a dedicated css minifier, for instance see less-plugin-clean-css.
FileError: 'colors.less' wasn't found. Tried - /home/ubuntu/cograph/app/assets/stylesheets/colors.less,/home/ubuntu/cograph/app/assets/stylesheets/colors.less,colors.less in /home/ubuntu/cograph/app/assets/stylesheets/graph.less on line 4, column 1:
3 @import "font";
4 @import "colors";
5

-- from https://circleci.com/gh/harlantwood/cograph/43

davidfurlong commented 9 years ago

Ah I removed it, because it was unused but I guess its still referenced.. fixing

davidfurlong commented 9 years ago

@harlantwood Its fixed

harlantwood commented 9 years ago

Nice. Next error is NameError: variable @black is undefined in /Users/harlan/HKB/code/cograph/app/assets/stylesheets/graph.less on line 168, column 9

@davidfurlong you should be able to repro these locally by running bin/compile.

davidfurlong commented 9 years ago

Nice. Next error is NameError: variable @black is undefined in /Users/harlan/HKB/code/cograph/app/assets/stylesheets/graph.less on line 168, column 9

@davidfurlong you should be able to repro these locally by running bin/compile.

Alright I guess colors.less was used here.. Ill run through these errors locally

davidfurlong commented 9 years ago

@harlantwood It successfully compiled locally for me now, apologies for the silly errors

harlantwood commented 9 years ago

NP!

Locally and on CI I now get:

Error: Error: ENOENT, no such file or directory '[some/local/path]/cograph/app/assets/stylesheets/main-graph.css'

Does your bin/compile succeed locally @davidfurlong?

davidfurlong commented 9 years ago

@harlantwood Ah It does, but it seems the .gitignore on the .css files means I didn't commit them. Doing so now

harlantwood commented 9 years ago

LGTM. Deploys successfully to my test heroku app. @willzeng same?

willzeng commented 9 years ago

This deploys successfully for me, but it still throws the same errors when looking for the .js. Check the console at http://graphdocs-test.herokuapp.com/