wilminator / dokuwiki-plugin-twofactor

Two factor authentication plugin for DokuWiki
GNU General Public License v2.0
2 stars 5 forks source link

Unable to Configure Two-Factor User Settings on Greebo #9

Open nosbig opened 6 years ago

nosbig commented 6 years ago

I had a test wiki from the previous release of Dokuwiki which was presenting the "Two-Factor Settings" link next to my user link in the upper-right corner of the screen. After upgrading to the latest release of DW (Greebo), this link never appears next to my user link.

ffito commented 6 years ago

I'm having this same issue with Greebo. TwoFactor admin page is showing only one user, and not even him can see the TwoFactor Settings link. Email plugin worked with his account though, but not with others.

Edit: still not sure if this issue is related to TwoFactor or to Attribute

Draky50110 commented 6 years ago

Fresh install of Greebo : same problem. One of 2FA plugins is (are) not compatible with Greebo :(

Ryonez commented 6 years ago

I'm not the only one then. No link for users to set up the plugin on their end.

Though I've had this for the last 3 versions of doku wiki. This plugin has never worked properly for me.

wilminator commented 6 years ago

I'm looking into the Greebo anomaly. @Ryonez, please clarify "never worked properly". We are discontinuing use of doku at work :( but I want to see this keep working for now.

Ryonez commented 6 years ago

The user link to access the TwoFactor configuration page is nowhere to be found.

I can enforce it, which makes it appear when they log in next, but I want it as opt-in. And they have no way to do so without that link.

wilminator commented 6 years ago

@Ryonez thanks for the additional info. I will look into it more.

wilminator commented 6 years ago

Short answer- Dokuwiki changed how to add menu items the end of last year. I'm working on replacing what broke now while leaving the old code in for backwards compatibility.

wilminator commented 6 years ago

Okay, the menu change I made is running on my development box. I have released it. Please update and confirm that the menu is working for you as well.

@Ryonez I am now looking into what you are seeing. Might be a couple days, but I will try to get this wrapped up for you.

wilminator commented 6 years ago

@Ryonez this appears to fix your problem. My development box is set to opt-in, and I now get the link if I am logged in but not using 2FA.

Ryonez commented 6 years ago

@wilminator I feel this was closed prematurely, as we hadn't even reported back on the outcome.

The link still doesn't appear for me. I'm not even sure where it's meant to be. Just in case it was the template (bootstrap3), I set it back to dokuwiki, with no success.

wilminator commented 6 years ago

Sorry about that, and you are right about me needing to leave it open for feedback. Please confirm the version of DokuWiki you are using; this can be found by following the directions posted at https://www.dokuwiki.org/faq:version

nosbig commented 6 years ago

@wilminator I can confirm that with an update to the twofactor core plugin to the 2018-06-20 version, I was able to see the 2FA profile link after logging out and back in.

I am running an up to date Greebo.

wilminator commented 6 years ago

@nosbig thanks for the confirmation. If I can get a couple more confirms I will update the official DW page to support Greebo.

ffito commented 6 years ago

I'll try to confirm tomorrow. Just wanted to add that I'm running Frusterick and it works ok, but not with Bootstrap template. I have to use the default template for the TwoFactor Settings link to show up. I guess that's a Bootstrap issue

Ryonez commented 6 years ago

Here's the check information: image

Draky50110 commented 6 years ago

I confirm that with default template and Greebo, it works perfectly with the last release/commits. Menu item is ok.

wilminator commented 6 years ago

@ffito Which bootstrap module(s) are you using?

wilminator commented 6 years ago

@Ryonez I think I have found a problem with the bootstrap3 template. I need to do more digging to confirm, but it appears that the author has hard-coded the entries in the user menu. I want to research this a little more to confirm what I'm seeing and see if I can help fix this issue rather than just throw this problem over their way.

Ryonez commented 6 years ago

@wilminator So it would show from just having the extension active then.

Would explain why trying to use the default template didn't change anything.

ffito commented 6 years ago

@wilminator I was using bootstrap3 template, but as it failed (and I really needed TwoFactor) I uninstalled it, can't remember now how it was configured

wilminator commented 6 years ago

I think I have a fix for the bootstrap3 template, but it relies on the old menu manipulation functionality. The good news it that I did not remove that functionality from my plugin because I want to cover the widest use case, so I support both the old Frusterick way and the new Greebo way.

I'm going to push an update to the maintainers of bootstrap3 and we will go from there. In the meantime, I will post the patch file that you can use to implement the fix manually.

wilminator commented 6 years ago

I have posted my bootstrap3 patch file. It is a one line addition, so it's not too difficult to hack in by hand if you want to try it.

ffito commented 6 years ago

I've just seen this, thanks!. We updated to Greebo and it's working fine with the latest version of Twofactor. Our wiki is in production now, and I no longer have access to the server, but I'll test the patch in a vm if I have some time

ffito commented 6 years ago

Not sure if this is related, but I have another issue: I'm only using the Google Authenticator module (Email module is installed but disabled), and when the sessions time out, Twofactor asks for a verification code that is not the one from Google auth. It seems to be the email code, but none is sent to the user address (which is normal, since that module it's not configured)

image

wilminator commented 6 years ago

@ffito That is related to #10 and I thought I had released a fix for it. Please follow up with this specific issue there.

wilminator commented 6 years ago

I discovered an error in the email module that broke it for login. This has been fixed and the update released.

wilminator commented 6 years ago

@Draky50110 I have pushed another change that should address your notification problem. I have also reworked the workflow to better handle turning on and off the twofactor module at large. This should also ensure that you are prompted for a password when you login and have anything configured and ready to go. Please confirm. Thanks!

wilminator commented 6 years ago

Last call for further problems with this issue.

ffito commented 6 years ago

So far so good. Couldn't test it with Bootstrap though, can anyone confirm if it works?

3ruce commented 5 years ago

This doesn't work with the bootstrap template but it works fine with the default template.... Everything has been freshly installed today....