search

wilr / grunt-shopify

Grunt plug-in for publishing Shopify theme assets
BSD 3-Clause "New" or "Revised" License
107 stars 32 forks source link

patching binary file uploads #11

Closed pagameba closed 11 years ago

pagameba commented 11 years ago

The binary file upload was not working for me for two reasons. First, the data was not getting properly base64 encoded. Second, the target for binary data is attachment rather than value.

My git skills are weak, I tried to do this in a clean branch but managed to include commits from master by accident and now I can't seem to get rid of them. This PR should apply on top of #10 without difficulty though.

wilr commented 11 years ago

Thanks!

wilr commented 11 years ago

Tested locally and no issues for syncing files. Still get an error deleting assets but that's a separate issue (#5).