wilr / grunt-shopify

Grunt plug-in for publishing Shopify theme assets
BSD 3-Clause "New" or "Revised" License
107 stars 32 forks source link

Support for Theme ID? #24

Closed justinmetros closed 10 years ago

justinmetros commented 10 years ago

New to your grunt-shopify project and looking forward to adding it to our workflow.

Until now, we've been building on one hand and using shopify_theme on the other. Having everything under one roof is definitely very nice!

Wondering if its possible to support themeid, so one could upload to an unpublished theme using this plugin. We use unpublished themes as development areas since all the store info is there. Not a biggie to get around using shopify_theme, but def would be a nice feature to keep everything clean and in one place in our Gruntfile.

I saw in lieu of donations you recommend Charity Water, our pleasure to support them. Thank you, and keep up the great work!

michaelrshannon commented 10 years ago

@wilr Following your merge of the above PR, this issue can probably now be closed.

wilr commented 10 years ago

Thanks @michaelrshannon

justinmetros commented 10 years ago

Wonderful! Thank you @wilr @michaelrshannon !!!

michaelrshannon commented 10 years ago

@justinmetros Let me know how you get on with this!