search

wilr / grunt-shopify

Grunt plug-in for publishing Shopify theme assets
BSD 3-Clause "New" or "Revised" License
107 stars 32 forks source link

Fix Windows File Paths #26

Closed mjaverto closed 10 years ago

mjaverto commented 10 years ago

I had trouble using this with Windows (heh, I know) but it was simply the filepath was wrong when sending to Shopify yielding a 404.

instead of 

assets/page.liquid

windows would use 

\assets\page.liquid

I put in a simple string replace to to fix and it is working great,

Also, I just tweaked the readme to add a little clarity for the 'base' option as that tripped me up for a few minutes.

wilr commented 10 years ago

Thanks!

mjaverto commented 10 years ago

NP found a few other things (windows specific like subfolders; ie customers/register.liquid) I'll need to send for a PR for but I want to fully test. Awesome plugin. Saved us tons of time. Thanks Will

michaelrshannon commented 10 years ago

Hi @mjaverto - did you make any progress on the subfolders issue? Was going to take a look at fixing, but no point if you've already resolved it!

mjaverto commented 10 years ago

@michaelrshannon I did, I just wanted to test with it for a while. I think it is good and I'll probably submit a pull request in the coming week or two but you can grab my code here for now: https://github.com/mjaverto/grunt-shopify

That should have the fix for subfolders.

michaelrshannon commented 10 years ago

Brilliant - thanks! Actually found this plugin via your post from last month, so thanks for highlighting this!

mjaverto commented 10 years ago

@michaelrshannon Sure. That post actually would explain how to install via NPM with my Repo for now.

Out of curiosity, can you let me know if you have any issues in the comments on that post? Some users have been having duplicate folder issues with Windows XP & 7 but I suspect mis-configuration on their side rather than the plugin itself. I personally did all testing in Windows 8.1.

michaelrshannon commented 10 years ago

Followed your instructions initially, then switched back to wilr:master as have been working on adding the ability to specify a particular theme, instead of only interacting with the live theme (PR following shortly), and found this thread when trying to identify if it was a bug I had introduced. Once I've submitted that PR I'll circle back around and test the subfolders issue, and reply to your post on how I get on.

michaelrshannon commented 10 years ago

@mjaverto The changes in your fork seem to be working fine for me (used with a couple of shops now to test), and don't seem to cause any problems on an OSX setup either :)