search

wilr / grunt-shopify

Grunt plug-in for publishing Shopify theme assets
BSD 3-Clause "New" or "Revised" License
107 stars 32 forks source link

Reports successful push even when it clearly failed. #29

Closed KenzieRudolphWilson closed 10 years ago

KenzieRudolphWilson commented 10 years ago

After realizing uploads aren't working at all, I tried to diagnose a problem. Nothing I did could cause a failed upload notification, even when I tried altering the API password to something clearly wrong. capture

ctalkington commented 10 years ago

my pr #30 would most likely resolve this since it uses a lib to standardize the error handling (handles actual error responses from Shopify and the normal HTTP/JSON parse) vs the way its currently a mix match of http requests which different error handling in each.

ctalkington commented 10 years ago

once that PR is accepted, i have a change to make the watching a bit smarter. right now it runs on every event and tends to upload before other tasks finish in my testing.

wilr commented 10 years ago

@ctalkington do you want to push those changes along with your rewrite PR so that I can test the sum of the changes in one go?

ctalkington commented 10 years ago

actually not sure that my watch changes make sense as a standard. requires few custom things to config.