search

wilr / grunt-shopify

Grunt plug-in for publishing Shopify theme assets
BSD 3-Clause "New" or "Revised" License
107 stars 32 forks source link

Easier hiding of API Key and Password #3

Closed ryanburnette closed 11 years ago

ryanburnette commented 11 years ago

@wilr

You could pull in the API Key and Password from another file then encourage users to add that file to their .gitignore. This would also help teams use their own credentials with the same project.

I can do a fork and pull request if you want.

wilr commented 11 years ago

Sure thing, though you should be able to do that by editing your applications Grunt file rather than requiring any updates to the plugin. Don't really need to couple the module to configuration management. For instance, you could use environment variables by changing your grunt file to something like

options: { api_key: process.env.GRUNT_SHOPIFY_KEY, password: process.env.GRUNT_SHOPIFY_PASSWORD, url: process.env.GRUNT_SHOPIFY_SHOP }

Then each user could set the env independently and not in SCM.

ryanburnette commented 11 years ago

Yea that's a good point. I'll do it that way rather than tinker with a good thing. ;)