search

wilr / grunt-shopify

Grunt plug-in for publishing Shopify theme assets
BSD 3-Clause "New" or "Revised" License
107 stars 32 forks source link

Major Refactor #30

Closed ctalkington closed 10 years ago

ctalkington commented 10 years ago

this PR breaks up logic from task registration, makes use of shopify-api (which I maintain), and overall just improves the code flow of this task. i've tried to break up the commits to make it easier to follow.

this should be considered a new minor release (v0.4.0). i have used a rougher variation of this code in production but could use a bit of testing around growl and cross platform (im on windows).

wilr commented 10 years ago

Thanks, as it's a major refactor and not like there are unit tests I will need to review this patch over the weekend in my production sites rather than just clicking the green button

ctalkington commented 10 years ago

totally understand. let me know if i happen to have missed anything ;)

wilr commented 10 years ago

Tested, merged into master and published 0.4.0 release. Thanks! defiantly cleaner using shopify-api :)

ctalkington commented 10 years ago

nice glad it worked out. I noticed a few things with api error detecting (reading error instead of errors key). I will patch that up soon and push new bug fix release.

wilr commented 10 years ago

Thanks, yeah I noticed that the err value would be empty but error code present in the response. Wasn't sure whether that was an issue with the shopify API not using the correct status codes or what.