search

wilr / grunt-shopify

Grunt plug-in for publishing Shopify theme assets
BSD 3-Clause "New" or "Revised" License
107 stars 32 forks source link

watch logic #35

Closed ctalkington closed 10 years ago

ctalkington commented 10 years ago

ran into an issue when i have multiple watch targets and it would try to upload changed styl file. with latest shopify-api update to catch 404s this will return a decent error message but it shouldn't really be trying to upload anyways. on a side note the output is bit crazy.

watch: {
  package_update: {
    files: ['package.json'],
    tasks: ['stylus:style', 'rework:style']
  },
  style: {
    files: ['styl/**/*.styl'],
    tasks: ['stylus:style', 'rework:style']
  },
  shopify: {
    files: ['shop/**'],
    tasks: ['shopify']
  }
}

2014-02-24_1440

ctalkington commented 10 years ago

i should mention this is with watch v0.5.3, im not sure if it exists with v0.4.x line.

ctalkington commented 10 years ago

please hold off on any release with my other PR. fix for whitelisting paths is coming soon.

wilr commented 10 years ago

Merged PR. Reopen if this is still an issue