Fixes case where `shopify.downloadTheme` is broken on first try

wilr / grunt-shopify

Grunt plug-in for publishing Shopify theme assets

BSD 3-Clause "New" or "Revised" License

107 stars 32 forks source link

Fixes case where `shopify.downloadTheme` is broken on first try #39

Closed hparra closed 10 years ago

hparra commented 10 years ago

shopify.downloadTheme was calling shopify.download with original Shopify key. Passing this through shopify._makeAssetKey resulted in a relative URL, e.g. "../assets/logo.png", which is an invalid key.

By joining this key with base path we retain original interface of shopify.download, and in turn the shopify:download task.

sharma-abhishek-it commented 10 years ago

I was facing exactly the same issue. Thanks a lot. Please incorporate this change.

phawxby commented 10 years ago

Confirmed, this is good. Please merge