search

wilr / silverstripe-googlesitemaps

Google Sitemaps module for the SilverStripe CMS
BSD 3-Clause "New" or "Revised" License
74 stars 95 forks source link

Configuration option added to set change frequency #65

Closed nickspiel closed 10 years ago

nickspiel commented 10 years ago

Added a configuration option to override calculated change frequency on all instances.

tractorcow commented 10 years ago

I think it would bebetter to implement this in GoogleSiteMap:: get_frequency_for_class. This means anyone calling that method gets the correct value, otherwise it only works if being called from the extension.

Also, what if you wanted a default change frequency, but wanted to set one class to a different value? Wouldn't it be better to make this global config a fallback rather than an override?

nickspiel commented 10 years ago

I agree, will move it into GoogleSiteMap:: get_frequency_for_class and make it a fallback. Will update and resubmit.