wilson-eft / wilson

A Python package for the running and matching of Wilson coefficients above and below the electroweak scale
https://wilson-eft.github.io
MIT License
26 stars 19 forks source link

Wrong arguments in translators #103

Closed peterstangl closed 2 years ago

peterstangl commented 2 years ago

In the definitions of the translators in wilson/translate/__init__.py, in several functions the value of sectors is used as input for the argument parameters, like e.g. in https://github.com/wilson-eft/wilson/blob/6879cb3a55a5fa509321d067962debc21f021703/wilson/translate/__init__.py#L37-L38 where the definition of the function warsaw_to_warsaw_up is https://github.com/wilson-eft/wilson/blob/6879cb3a55a5fa509321d067962debc21f021703/wilson/translate/smeft.py#L66

As long as sectors is None this can remain unnoticed (since None is a valid input for parameters).

DavidMStraub commented 2 years ago

Oh. Lesson: never use positional args.

peterstangl commented 2 years ago

This issue has been fixed in PR #104. The bug fix is included in wilson v2.3.2.