[translate] Fix handling of complex-valued WCs in translation to EOS WET basis.

wilson-eft / wilson

A Python package for the running and matching of Wilson coefficients above and below the electroweak scale

https://wilson-eft.github.io

MIT License

26 stars 19 forks source link

[translate] Fix handling of complex-valued WCs in translation to EOS WET basis. #39

Closed dvandyk closed 4 years ago

dvandyk commented 4 years ago

Following changes to the EOS WET basis; see PR #4 in wcxf/wcxf-bases.

dvandyk commented 4 years ago

Can somebody tell me why this suddently does not work? I copied the code, literally, from one line to another...

dvandyk commented 4 years ago

Apparently Python is fine with arbitrary indentations in multiline statements within the right-hand side of a dict's key/value pair, but not for an assignment. Parentheses to the rescue!

@DavidMStraub I think merging this requires merging the wcxf-bases one first. Correct?

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 196

7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.01%) to 89.899%

Totals
Change from base Build 190:	0.01%
Covered Lines:	5634
Relevant Lines:	6267

💛 - Coveralls

dvandyk commented 4 years ago

@peterstangl can you review and merge this please?

DavidMStraub commented 4 years ago

I added @jasonaebischerGIT as repository admin now. I can also merge it, but didn't have time to look at it...

dvandyk commented 4 years ago

@DavidMStraub ah, ok! I thought Peter had also taken over maintaining wilson. Can I suggest to present the contact details of the maintainer on the project's README.md?

dvandyk commented 4 years ago

@jasonaebischerGIT @DavidMStraub I have added to changes to the README. First, referring to the Stoffer/Dekens 1-loop paper. Second, mentioning that Jason is the maintainer of the package.

DavidMStraub commented 4 years ago

We haven't actually discussed that so far :thinking:

Let's leave the Readme change separate from this FTTB.

dvandyk commented 4 years ago

Fine by me. Reverted to the old branch.

dvandyk commented 4 years ago

@jasonaebischerGIT ping!

DavidMStraub commented 4 years ago

Can be merged I think.

jasonaebischerGIT commented 4 years ago

Sorry, I did not get the notifications, since my tum mail does not work anymore. Can be merged, yes.

dvandyk commented 4 years ago

@jasonaebischerGIT excellent, but I cannot merge it! :-)

jasonaebischerGIT commented 4 years ago

I am not sure how. I don't think I am admin yet....

DavidMStraub commented 4 years ago

I'll try cancelling the invite and sending it out again. Please check your spam folder in case.

In the meantime I'll merge this.

dvandyk commented 4 years ago

Thanks David!

jasonaebischerGIT commented 4 years ago

Thanks David, I think it works now!