search

wilson-labs / cola

Compositional Linear Algebra
Apache License 2.0
326 stars 24 forks source link

fix for negatively indexed (off)diagonal #51

Closed Fr0do closed 10 months ago

Fr0do commented 10 months ago

Fix a bug with number of elements with negative values of diagonal.

codecov[bot] commented 10 months ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.20% :tada:

Comparison is base (8afd707) 78.48% compared to head (282b308) 78.68%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #51 +/- ## ========================================== + Coverage 78.48% 78.68% +0.20% ========================================== Files 36 36 Lines 2975 2975 ========================================== + Hits 2335 2341 +6 + Misses 640 634 -6 ``` | [Files Changed](https://app.codecov.io/gh/wilson-labs/cola/pull/51?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wilson-labs) | Coverage Δ | | |---|---|---| | [cola/linalg/diag\_trace.py](https://app.codecov.io/gh/wilson-labs/cola/pull/51?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wilson-labs#diff-Y29sYS9saW5hbGcvZGlhZ190cmFjZS5weQ==) | `87.67% <100.00%> (+8.21%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mfinzi commented 10 months ago

Good catch, thanks @Fr0do ! Another 🐞 squashed :)