wilson-labs / cola

Compositional Linear Algebra
Apache License 2.0
326 stars 24 forks source link

Hutch++ #52

Open Fr0do opened 10 months ago

Fr0do commented 10 months ago

Resolves #47

codecov[bot] commented 10 months ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.23% :tada:

Comparison is base (64c2fd6) 78.62% compared to head (0f8262d) 78.85%.

:exclamation: Current head 0f8262d differs from pull request most recent head 8014329. Consider uploading reports for the commit 8014329 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #52 +/- ## ========================================== + Coverage 78.62% 78.85% +0.23% ========================================== Files 36 36 Lines 2975 2998 +23 ========================================== + Hits 2339 2364 +25 + Misses 636 634 -2 ``` | [Files Changed](https://app.codecov.io/gh/wilson-labs/cola/pull/52?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wilson-labs) | Coverage Δ | | |---|---|---| | [cola/algorithms/diagonal\_estimation.py](https://app.codecov.io/gh/wilson-labs/cola/pull/52?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wilson-labs#diff-Y29sYS9hbGdvcml0aG1zL2RpYWdvbmFsX2VzdGltYXRpb24ucHk=) | `81.25% <100.00%> (+4.84%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/wilson-labs/cola/pull/52/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wilson-labs)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mfinzi commented 10 months ago

I wonder if it would be worth looking into the single pass estimator in https://arxiv.org/abs/2109.10659, @Fr0do do you have any thoughts on the differences between the different $O(1/\epsilon)$ algorithms?