Open Fr0do opened 1 year ago
Patch coverage: 100.00%
and project coverage change: +0.33%
:tada:
Comparison is base (
f40c7e1
) 78.44% compared to head (0ae5c03
) 78.78%.:exclamation: Current head 0ae5c03 differs from pull request most recent head 190f9f4. Consider uploading reports for the commit 190f9f4 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I didn't realize you're on a fork, I made some edits and here is a diff: diff_output.txt
Though the tests pass (with the adjustment to take into account that fixed_normal_samples -> randn
in a recent patch)
it seems that the Woodbury dispatch rules are not being hit. This isn't due to any incorrect usage or mistake on your end, but it looks to be a limitation (bug?) in plum-dispatch for parametric types. issubclass(A, Sum[TypeB, TypeC])
will evaluate to true while not matching the dispatch rule for A
. I will investigate if this is easily solvable in our cola-plum-dispatch
fork that we use.
I didn't realize you're on a fork, I made some edits and here is a diff: diff_output.txt
Is there a way to work collaboratively? I can add mainainers of CoLA to my fork as collaborators. Or maybe there is a way I can create a branch in your repo?
Low-rank dispatch rules for Woodbury Identity case of
inv
and computationally effectivetrace
of low-rank product, resolves #48