wilson-labs / cola

Compositional Linear Algebra
Apache License 2.0
326 stars 24 forks source link

Switching from absolute to relative tolerance for all algorithms #72

Closed AndPotap closed 10 months ago

AndPotap commented 10 months ago

Currently we are using stopping criteria based on absolute tolerances. This is not ideal for really large problems as a really low tolerance might be infeasible to achieve and therefore we are just running the algorithm to the max number of iters each time.

codecov[bot] commented 10 months ago

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.14% :warning:

Comparison is base (9e2f491) 77.74% compared to head (1977125) 77.60%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #72 +/- ## ========================================== - Coverage 77.74% 77.60% -0.14% ========================================== Files 39 39 Lines 3410 3372 -38 ========================================== - Hits 2651 2617 -34 + Misses 759 755 -4 ``` | [Files Changed](https://app.codecov.io/gh/wilson-labs/cola/pull/72?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wilson-labs) | Coverage Δ | | |---|---|---| | [cola/backends/torch\_fns.py](https://app.codecov.io/gh/wilson-labs/cola/pull/72?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wilson-labs#diff-Y29sYS9iYWNrZW5kcy90b3JjaF9mbnMucHk=) | `90.04% <ø> (+1.46%)` | :arrow_up: | | [cola/algorithms/arnoldi.py](https://app.codecov.io/gh/wilson-labs/cola/pull/72?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wilson-labs#diff-Y29sYS9hbGdvcml0aG1zL2Fybm9sZGkucHk=) | `63.97% <100.00%> (ø)` | | | [cola/algorithms/cg.py](https://app.codecov.io/gh/wilson-labs/cola/pull/72?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wilson-labs#diff-Y29sYS9hbGdvcml0aG1zL2NnLnB5) | `98.05% <100.00%> (-0.47%)` | :arrow_down: | | [cola/algorithms/lanczos.py](https://app.codecov.io/gh/wilson-labs/cola/pull/72?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wilson-labs#diff-Y29sYS9hbGdvcml0aG1zL2xhbmN6b3MucHk=) | `75.00% <100.00%> (+0.19%)` | :arrow_up: | | [cola/backends/jax\_fns.py](https://app.codecov.io/gh/wilson-labs/cola/pull/72?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=wilson-labs#diff-Y29sYS9iYWNrZW5kcy9qYXhfZm5zLnB5) | `96.55% <100.00%> (+0.01%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.