Closed AndPotap closed 11 months ago
Attention: 7 lines
in your changes are missing coverage. Please review.
Comparison is base (
7b9c0ac
) 81.95% compared to head (bffc6e8
) 81.82%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hey @mfinzi, could you take a look at this PR. Basically, I added some difficult sparse linear operators (from the matrix market) under tests/data and I'm calling them to tests different algorithms: CG, GMRES, Lanczos, Arnoldi and LOBPCG. I'm only enabling the smallest test for the majority of the algorithms as the other cases take hours to run. Maybe this is fine for some night runs, I guess not for when people are doing PRs...
Many of the unit tests that we have are simple cases that are far from the ones observed in real-life. With the goal of stress testing our implementations we selected a few matrix market benchmarks that can run in a reasonable time but that are also hard.