For UI, I noticed there is a large blank space below the instruction, we should remove this space. And for download button, this is a good addition, but should consider put in a more appropriate place, so user easier to locate the button, eg top right corner of the UI.
For table & graph, we can put the number formatting to currency, eg add thousand separator and put 2 decimal places
For graph, the legend seem to have some labels covered, we can remove label if any
We can enhance the table cell formatting by putting different cell/background color to differentiate which cell is input values and which is projected
wilson-pang
commented
3 months ago
Hi @wilson-pang , thanks for attempting the shiny assessment, please find my feedbacks below:
The interface fully fulfilled all requirements, user is able to input some data, calculate and visualize result all in the app, well done!
For tail factor, since this value normal ranges from 1 to 2, consider putting the
stepas 0.1, so user can increment the value in smaller step https://github.com/wilson-pang/R_Shiny_Assessment/blob/fcf0f932fd941267d22fb3301b762176cf153566/app1/app.R#L17For UI, I noticed there is a large blank space below the instruction, we should remove this space. And for download button, this is a good addition, but should consider put in a more appropriate place, so user easier to locate the button, eg top right corner of the UI.
For table & graph, we can put the number formatting to currency, eg add thousand separator and put 2 decimal places
For graph, the legend seem to have some labels covered, we can remove label if any
We can enhance the table cell formatting by putting different cell/background color to differentiate which cell is input values and which is projected
The code is easy to read and neat, but we can avoid loading the
rsconnectlibrary since this library only needed when we deploy, it is unnecessary for app running https://github.com/wilson-pang/R_Shiny_Assessment/blob/fcf0f932fd941267d22fb3301b762176cf153566/app1/app.R#L5