search

wilson1yan / VideoGPT

MIT License
968 stars 119 forks source link

shiftdim instead of torch.movedim #13

Closed FrancoisPgm closed 3 years ago

FrancoisPgm commented 3 years ago

https://github.com/wilson1yan/VideoGPT/blob/a259612b65a5de18c7d720b6e5f0c74e68338179/videogpt/utils.py#L3 In utils you define a shiftdim function that seems to do the same as torch.movedim. Is there a reason for re-implementing it ?

wilson1yan commented 3 years ago

I didn't know that torch.movedim existed. I guess I'll be using that in the future :)