In non-textMode, the css is put into a JS variable with double quotes. In this case, it makes sense to escape double quotes so that the concatenation isn't interrupted by the compiled CSS. However, single quotes should be allowed and not escaped (they currently are). This is especially important when doing things like:
content: '\\00bb' which is converted to content: \'\\00bb\' for no good reason. This basically makes it impossible to do something like this.
Locally, I've removed .replace(/'/g, '\\"'), but any chance we can get this on master? Or is there another reason that I'm missing on why this is necessary?
mmase
commented
9 years ago
In non-textMode, the css is put into a JS variable with double quotes. In this case, it makes sense to escape double quotes so that the concatenation isn't interrupted by the compiled CSS. However, single quotes should be allowed and not escaped (they currently are). This is especially important when doing things like:
content: '\\00bb'which is converted tocontent: \'\\00bb\'for no good reason. This basically makes it impossible to do something like this.Locally, I've removed
.replace(/'/g, '\\"'), but any chance we can get this on master? Or is there another reason that I'm missing on why this is necessary?