search

wilsoncai1992 / adaptest

Data-adaptive testing under high-dimensions
GNU General Public License v2.0
2 stars 3 forks source link

initial Origami attempt + bump up version #30

Closed wilsoncai1992 closed 6 years ago

wilsoncai1992 commented 7 years ago

@nhejazi please see the latest commit facb6ca for a refined test to target and check the discrepancy.

nhejazi commented 6 years ago

94d4874 introduces changes that allow the folds object (produced by origami::make_folds) from the new implementation to be passed to the old implementation. The tests comparing the objects produced by the new and old implementation now pass. Please check it out @wilsoncai1992.

wilsoncai1992 commented 6 years ago

good!

wilsoncai1992 commented 6 years ago

lets merge?

nhejazi commented 6 years ago

Sure, the implementation based on origami now works, so it makes sense to merge. Would you agree that next step should be fixing the problems found by devtools::check()? (e.g., documentation and such). This could happen via a new branch (named something like fix-rcmdcheck for example).