Closed WhyNotHugo closed 4 years ago
@wilsonfreitas Could you take a look at this PR? 🙏
OK, merged!
@wilsonfreitas Awesome, thank you!
I have made many changes in this project during the last week. Maybe a few things work differently. Please, let me know if you have any problem. Tks.
@wilsonfreitas Thanks! So far, the new version is looking good – haven't noticed any issues, and none of our tests have failed (many of which rely on this library). I'll let you know if we see any problems.
Using
type()
: checks that the type of an argument is EXACTLY a given class, and will not match if we're using a subclass.I'm using a project that uses freezegun for testing, so our date objects are actually subclasses of
datetime.date
, and not instances of exactly that class.This change does not break existing functionality, and should not break even under very odd scenarios which haven't been considered so far.