search

wilsonmr / anvil

Repository containing code related to flow based generative model
https://wilsonmr.github.io/anvil/
GNU General Public License v3.0
0 stars 2 forks source link

Update and add tests for distributions #73

Closed wilsonmr closed 3 years ago

wilsonmr commented 3 years ago

closes #72 and also follows the general policy of increasing coverage of docs and tests

jmarshrossney commented 3 years ago

Happy to make the very minor changes suggested above, let me know what you think.

wilsonmr commented 3 years ago

Yep go for it

jmarshrossney commented 3 years ago

Couldn't bring myself to change sigma to scale in the config parser - it'd probably do more harm than good!

wilsonmr commented 3 years ago

yeah the "idea" with these things is the high level interface is very well thought out and never changes (so the user can keep using their fantastic runcards) and the lower level interface can change with the wind.

In reality you always have to make these kinds of choices.

wilsonmr commented 3 years ago

haha, oops - forgot about the tests which check the low level interface 😄

jmarshrossney commented 3 years ago

crap..