search

wilsonpage / fastdom

Eliminates layout thrashing by batching DOM measurement and mutation tasks
6.85k stars 240 forks source link

Added NODE_ENV to configure debug mode #80

Open wardpeet opened 8 years ago

wardpeet commented 8 years ago

Make debug flag editable by setting NODE_ENV to production.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 98.4% when pulling b12898c103fbd1b1b84cb180b0364fc3aa3b8c48 on wardpeet:debugmode into bbdc19189b3ac4308fd55a17571347fcfec9c72a on wilsonpage:master.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 98.4% when pulling 640d02e23945512092866c3f866454dcc68ad4ce on wardpeet:debugmode into bbdc19189b3ac4308fd55a17571347fcfec9c72a on wilsonpage:master.

wardpeet commented 8 years ago

This would be handy when you use it with webpack, you can trigger debug mode

pke commented 6 years ago

Good patch to make the production bundle as small as possible. I wonder why the compiled libs are checked into the repo though. Shouldn't they just be deployed to npm?

wardpeet commented 6 years ago

no idea but repo has this so I thought i would ust do the same

pke commented 6 years ago

@wilsonpage why are the compiled versions checked in? @wardpeet maybe you can rebase and @wilsonpage can merge this then?

wilsonpage commented 6 years ago

@pke yes the compiled /fastdom-strict.js is checked in, just so consumers have the choice to load via <script> if need be.