search

wilsonpage / fastdom

Eliminates layout thrashing by batching DOM measurement and mutation tasks
6.83k stars 240 forks source link

90 version compat #91

Open wilsonpage opened 8 years ago

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-3.6%) to 94.815% when pulling a8145a4402c88632bf0225a5455897ac7c870b10 on 90-version-compat into 5614caa7cb6577810f836bb532098581f1283e42 on master.

wilsonpage commented 8 years ago

@indianburger can you review this and see if it fixes your issues?

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-3.6%) to 94.815% when pulling c5caec28f1ec41091c76310a5587e484f75c440c on 90-version-compat into aa3c897bcdff0ee182f29d9a45a03e709f529c8f on master.

wilsonpage commented 8 years ago

@indianburger I need to write some unit-tests, but don't want to block you 😃

I've added a pretty detailed comment above the new conflict resolution code. It's late and I'm tired, so I could have easily missed something.

wilsonpage commented 8 years ago

@indianburger what's your status? Have you found a workaround or are you still interested in this fix?

indianburger commented 8 years ago

Looks good and works for us. 👍🏾

indianburger commented 8 years ago

Also to note, we hacked a version together to unblock us temporarily. So feel free to take a bit more time to add tests and do it proper.

wilsonpage commented 8 years ago

Cool. I'm on vacation for the next week. I'll be able to take a look next week.

Exkaleburx commented 4 months ago

Start