search

wilsonrljr / sysidentpy

A Python Package For System Identification Using NARMAX Models
https://sysidentpy.org
BSD 3-Clause "New" or "Revised" License
380 stars 77 forks source link

root_relative_squared_error function #114

Closed miroder closed 1 year ago

miroder commented 1 year ago

the root_relative_squared_error function right now is

numerator = np.sum(np.square((yhat - y)))
denominator = np.sum(np.square((yhat - np.mean(y, axis=0))))
return np.sqrt(np.divide(numerator, denominator))

the denominator should be "np.sum(np.square((y- np.mean(y, axis=0))))" ?

Thx

wilsonrljr commented 1 year ago

Hey @miroder , that is correct. I fixed it and published in the new v0.3.2 version (which has some other changes). Thanks for catching that!