search

wilsonrljr / sysidentpy

A Python Package For System Identification Using NARMAX Models
https://sysidentpy.org
BSD 3-Clause "New" or "Revised" License
390 stars 78 forks source link

r2_score #91

Closed AntoineDubois closed 1 year ago

AntoineDubois commented 1 year ago

Hello, The metric r2_score is buggy for multidimensional input. One can quickly fix it by: sysidentpy.metrics.r2_score(Y_valid.flatten(), yhat.flatten()) I am sure modifying the underlying code would ease its use Thanks!

wilsonrljr commented 1 year ago

Hey, @AntoineDubois ! Thanks for open this issue. I was informed by another user about it and its already fix in the branch v0.2.2. I forgot to open an issue about it to get everyone warned.

The new version is already finished (I'm updating the docs because there is some breaking changes.. nothing critical, but I think it'll make the package usage easier to understand for beginners).

I'll try to release the new version til 11/02.

AntoineDubois commented 1 year ago

Thanks!

wilsonrljr commented 1 year ago

fixed in v0.3.0