search

wilsonrljr / sysidentpy

A Python Package For System Identification Using NARMAX Models
https://sysidentpy.org
BSD 3-Clause "New" or "Revised" License
390 stars 78 forks source link

Use flatten function to build matrix instead of array slicing syntax #93

Closed gamcorn closed 1 year ago

gamcorn commented 1 year ago

numpy flatten function was used to replace the array slicing syntax that is not compatible to the latests version of numpy.

wilsonrljr commented 1 year ago

Looking good, @gamcorn. I'll release a new update soon and I think we can add your fix on it. I'll merge v0.2.2 to master and ask you to rebase your branch and request again. I'll let you know.

Thank you!

Hey @gamcorn, I merged my updates on master already. Let me know when if/when you can rebase your code with master and push it again so we can follow with your pull request.

gamcorn commented 1 year ago

Hello @wilsonrljr, I merged your main on my branch, thanks !

wilsonrljr commented 1 year ago

The two tests that failed are simple to fix. The r2_score fail is related to a change I did and the other is a fix you did by using the "_mu" instead of "mu". I'll follow with the merge and I'll fix this two testes myself. Thank you again!