wilsto / smartNews

0 stars 0 forks source link

An in-range update of socket.io is breaking the build 🚨 #11

Open greenkeeper[bot] opened 6 years ago

greenkeeper[bot] commented 6 years ago

☝️ Greenkeeper’s updated Terms of Service will come into effect on April 6th, 2018.

Version 2.1.0 of socket.io was just published.

Branch Build failing 🚨
Dependency socket.io
Current Version 2.0.4
Type dependency

This version is covered by your current version range and after updating it in your project the build failed.

socket.io is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details - ❌ **continuous-integration/travis-ci/push** The Travis CI build could not complete due to an error [Details](https://travis-ci.org/wilsto/smartNews/builds/360081729?utm_source=github_status&utm_medium=notification)

Release Notes 2.1.0

Features

  • add a 'binary' flag (#3185)
// by default, the object is recursively scanned to check whether it contains some binary data
// in the following example, the check is skipped in order to improve performance
socket.binary(false).emit('plain-object', object);

// it also works at the namespace level
io.binary(false).emit('plain-object', object);
  • add support for dynamic namespaces (#3195)
io.of(/^\/dynamic-\d+$/).on('connect', (socket) => {
  // socket.nsp.name = '/dynamic-101'
});

// client-side
const client = require('socket.io-client')('/dynamic-101');

Bug fixes

  • properly emit 'connect' when using a custom namespace (#3197)
  • include the protocol in the origins check (#3198)

Important note ⚠️ from Engine.IO 3.2.0 release

There are two non-breaking changes that are somehow quite important:

  • ws was reverted as the default wsEngine (socketio/engine.io#550), as there was several blocking issues with uws. You can still use uws by running npm install uws --save in your project and using the wsEngine option:
var engine = require('engine.io');
var server = engine.listen(3000, {
  wsEngine: 'uws'
});

Milestone: 2.1.0
Diff: 2.0.4...2.1.0
Engine.IO version: 3.2.x

Commits

The new version differs by 14 commits.

  • db831a3 [chore] Release 2.1.0
  • ac945d1 [feat] Add support for dynamic namespaces (#3195)
  • ad0c052 [docs] Add note in docs for origins(fn) about error needing to be a string. (#2895)
  • 1f1d64b [fix] Include the protocol in the origins check (#3198)
  • f4fc517 [fix] Properly emit 'connect' when using a custom namespace (#3197)
  • be61ba0 [docs] Add link to a Dart client implementation (#2940)
  • c0c79f0 [feat] Add support for dynamic namespaces (#3187)
  • dea5214 [chore] Bump superagent and supertest versions (#3186)
  • b1941d5 [chore] Bump engine.io to version 3.2.0
  • a23007a [docs] Update license year (#3153)
  • f48a06c [feat] Add a 'binary' flag (#3185)
  • 0539a2c [test] Update travis configuration
  • c06ac07 [docs] Fix typo (#3157)
  • 52b0960 [chore] Bump debug to version 3.1.0

See the full diff

FAQ and help There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).

Your Greenkeeper Bot :palm_tree:

greenkeeper[bot] commented 6 years ago

After pinning to 2.0.4 your tests are still failing. The reported issue might not affect your project. These imprecisions are caused by inconsistent test results.

greenkeeper[bot] commented 6 years ago

Version 2.1.1 just got published.

Your tests are still failing with this version. Compare the changes 🚨

Commits

The new version differs by 4 commits.

  • e0b2cb0 [chore] Release 2.1.1
  • 1decae3 [feat] Add local flag to the socket object (#3219)
  • 0279c47 [docs] Convert the chat example to ES6 (#3227)
  • 2917942 [docs] Clarify private messaging in the emit cheatsheet (#3232)

See the full diff