search

wilzbach / msa

Modular BioJS compoment for a multiple sequence alignment
http://msa.biojs.net
Boost Software License 1.0
168 stars 79 forks source link

hide non-polymorphic sites feature added to the filter menu #188

Open bfrgoncalves opened 8 years ago

bfrgoncalves commented 8 years ago

Option to hide non-polymorphic sites. It hides the columns which nucleotide identity at a given position is above the threshold.

Bruno Gonçalves

wilzbach commented 8 years ago

Option to hide non-polymorphic sites. It hides the columns which nucleotide identity at a given position is above the threshold.

Thanks. Looks all good to me :+1:

I had some minor comments about the style though, do you mind addressing them?

bfrgoncalves commented 8 years ago

Thanks for the comments for code improvement =) I reused your code from one of the filter options to create this new one but I will change the code and pull it here.

wilzbach commented 8 years ago

Thanks for the comments for code improvement =) I reused your code from one of the filter options to create this new one but I will change the code and pull it here.

Yep as said, some parts are still "dirty" as they were converted from CoffeeScript. Did you manage to adapt the changes? (I can't see them here). If you ran into troubles, let me know ;-)

wilzbach commented 8 years ago

ping @bfrgoncalves ;-)