search

wilzbach / msa

Modular BioJS compoment for a multiple sequence alignment
http://msa.biojs.net
Boost Software License 1.0
168 stars 79 forks source link

Overview size #208

Closed alpae closed 7 years ago

alpae commented 8 years ago

This is a pull request to fix the issue in #207, i.e. it rescales the overview view to the size of the parent div, if zoomer.overviewboxWidth === 'auto' and limits the height of the overview if zoomer.overviewboxHeight is set to a fixed size. The default behaviour (parameters both set to 'fixed', the existing behaviour is maintained.

wilzbach commented 8 years ago

This is a pull request to fix the issue in #207,

Thanks a lot for your work! I just had a quick look & it looks nice. Unfortunately I am a bit low on time, but I will definitely test & review it properly tonight ;-)

zachcp commented 7 years ago

Hi @wilzbach,

Thank you for your wonderful library. I'm sure you are quite busy but is there any chance you could take a look at this PR? It would be a valuable addition to the library. And as @robear22890 has referenced - we are interested in using it in an msa wrapper for R.

Thank You, zach cp

grabear commented 7 years ago

Yes. I'm not sure if @alpae could be of any help as well.