search

wilzbach / msa

Modular BioJS compoment for a multiple sequence alignment
http://msa.biojs.net
Boost Software License 1.0
168 stars 79 forks source link

msa.js doesn't work with Firefox Nightly 85 #257

Closed MrTomRod closed 2 years ago

MrTomRod commented 3 years ago

Thanks for your great work!

Using Firefox Nightly 85.0a1 (2020-12-09) on http://msa.biojs.net/ I get the following error in my console:

Uncaught TypeError: t.on is not a function
    resetSeqs index.js:58
    e index.js:56
    resetSeqs index.js:59
    t index.js:14
    _loadSeqs msa.js:121
    initialize msa.js:79
    Backbone 3
    <anonymous> norowuvoqo.js:18
index.js:58:9
    resetSeqs index.js:58
    e index.js:56
    resetSeqs index.js:59
    t index.js:14
    _loadSeqs msa.js:121
    initialize msa.js:79
    Backbone 3
    <anonymous> norowuvoqo.js:18

Maybe it's just the a nightly bug, but it could be worth looking into this error before Firefox 85 becomes mainline.

MrTomRod commented 3 years ago

Problem still exists in Firefox 85 and is also present in Firefox 86.

Firefox 85 will be released very soon! (2021-01-26)

Please fix this bug soon, I rely on it!

MrTomRod commented 3 years ago

Still broken on Firefox 90.0 (64-Bit)...

MrTomRod commented 3 years ago

Found a dirty workaround: Simply remove this from msa.js:

t.on("add change reset ",e,this),e.call(this)

alt text

guignonv commented 3 years ago

If I may, I think the correct fix is not to comment "t.on("add change reset ",e,this),e.call(this)" but rather turn the "at" into an "on" a few characters before: if(this.seqs=[],!t instanceof Array||"on"in t) (instead of if(this.seqs=[],!t instanceof Array||"at"in t)). ;-)

MrTomRod commented 3 years ago

Wow, how the hell did you divine this? :rofl: Thanks.

slimsuite commented 3 years ago

Hi, I've also been having problems that alignments have stopped displaying. Does the above fix mean that the tool will become available again soon? It's really useful! (Well done, and thanks!) (I am using it with <script src="https://cdn.bio.sh/msa/latest/msa.min.gz.js"></script>)

MrTomRod commented 3 years ago

I would not count on it - the developer has moved on to other things. Just host an edited version of msa.js yourself. (If you can't, and you trust me, and need a short-term solution, you can use this: <script src="https://opengenomebrowser.bioinformatics.unibe.ch/static/align/js/msa.min.js"></script>)