search

wilzbach / tools-test

1 stars 0 forks source link

auto-tester doesn't run rdmd_test (causes a number of regressions in each release) #153

Open wilzbach opened 7 years ago

wilzbach commented 7 years ago

Note: the issue was created automatically migrated from https://issues.dlang.org

Original bug ID: BZ#16953 From: Timothee Cour <timothee.cour2@gmail.com> Reported version: D2 CC: dlang-bugzilla@thecybershadow.net

wilzbach commented 7 years ago

Comment author: Timothee Cour <timothee.cour2@gmail.com>

from https://issues.dlang.org/show_bug.cgi?id=16952:

Regarding the issue that this stuff comes up again and again: We do have a test in rdmd_test.d [1], and it does catch this. I think the problem is that the auto-tester doesn't run rdmd_test.

and past related bugs: https://issues.dlang.org/show_bug.cgi?id=15175 rdmd --loop and --eval now complain about std.stream deprecation warnings https://issues.dlang.org/show_bug.cgi?id=13288 rdmd --eval fails because it still imports std.metastrings https://issues.dlang.org/show_bug.cgi?id=10352 Regression (2.063): --eval is broken in RDMD

wilzbach commented 7 years ago

Comment author: Vladimir Panteleev <dlang-bugzilla@thecybershadow.net>

FWIW, we do run the rdmd test suite via Travis (see https://github.com/dlang/tools/blob/master/travis.sh), but this only runs for PRs against the tools repository. We need to run the tests against PRs to all repositories to catch such issues effectively.

We also have a daily cron job configured on Travis, so we can now at least be informed of such breakages shortly after they happen.

Integrating the test into the auto-tester would be nice, however it currently doesn't test the tools repo at all. What might be more likely to happen instead is that I expand DAutoTest to also run the tools repository tests.