search

wilzbach / tools-test

1 stars 0 forks source link

Bugzilla integration fails with reverts and multiple branches #158

Open wilzbach opened 7 years ago

wilzbach commented 7 years ago

Note: the issue was created automatically migrated from https://issues.dlang.org

Original bug ID: BZ#17044 From: Dicebot <public@dicebot.lv> Reported version: D2 CC: @wilzbach

wilzbach commented 7 years ago

Comment author: Dicebot <public@dicebot.lv>

Now that there are at least two development branches (master and stable), simplicity of GitHub bugzilla integration becomes a problem.

Consider https://issues.dlang.org/show_bug.cgi?id=16193 - it got originally fixed with a commit mentioning "fix Issue 16193". Later it got reverted (with an auto-generated commit saying "Revert "fix Issue 16193 ...") and matching issues was reopened.

But when revert commit got merged into another branch, bugzilla integration hook has detected the very same "fix Issue 16193" substring and closed issue again as fixed (but it wasn't).

Best solution would be for hook to actually recognize revert commits as having inverse effect of "fixes" mention but I don't know if it can be configured as such.

wilzbach commented 7 years ago

Comment author: anonymous4 <dfj1esp02@sneakemail.com>

Or just do nothing for merges.

wilzbach commented 6 years ago

Comment author: @wilzbach

The Bugzilla integration has been changed to be only active for master. This should reduce the noise significantly.