wimb0 / home-assistant-saj-r5-modbus

Home Assistant Component for reading data locally from SAJ R5 (and Zonneplan One) Inverters through modbus TCP.
MIT License
32 stars 14 forks source link

Update Limit Power entity to match actual device behavior #89

Closed mvn23 closed 3 months ago

mvn23 commented 3 months ago

After running some tests it seems that the inverter resets its output limit to 110% every time mpvmode changes to 2 (Normal). This PR is meant to reflect that behavior in the following ways:

One potential issue with this method is that the Limit Power entity may de-synchronize from the actual limit. This will happen in case of a re-load of the integration after setting a lower limit while mpvmode remains 2 in the inverter. A possible solution to this would be to actively set the limit to 110% when mpvmode changes to 2. If this is deemed desirable then I will update the PR. Otherwise users can do this with a simple automation.

fixes #86

wimb0 commented 3 months ago

Great work, thanks!